Skip to content

test: add end-to-end integration tests for secure parameters - #782

Open
anubhav756 wants to merge 1 commit into
anubhav-secure-params-llamaindexfrom
anubhav-secure-params-e2e
Open

test: add end-to-end integration tests for secure parameters#782
anubhav756 wants to merge 1 commit into
anubhav-secure-params-llamaindexfrom
anubhav-secure-params-e2e

Conversation

@anubhav756

@anubhav756 anubhav756 commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Overview

This PR adds E2E integration tests for Secure Parameters across Python SDKs.

The tests verify that secure parameters defined in the manifest (tools.yaml with secure: true) are properly hidden from client-side public schemas (__signature__ and docstrings) and can be bound out-of-band via literal values or dynamic callables (sync & async) and successfully sent over the wire (secureArguments) to the Toolbox server during live execution.

Also updated _TOOLBOX_MANIFEST_VERSION from 34 to 38 across all integration.cloudbuild.yaml configurations, which contains a new test tool with secure params.

Note

These integration tests depend on the server-side Secure Parameters feature currently in googleapis/mcp-toolbox#3394.

In presubmits, these tests will fail until the server-side PR is merged and released into the toolbox server binary. Verified locally by building the binary from the feature branch.

@anubhav756
anubhav756 force-pushed the anubhav-secure-params-e2e branch 5 times, most recently from 192541b to 249e5b5 Compare August 20, 2026 08:51
@anubhav756
anubhav756 marked this pull request as ready for review August 20, 2026 08:57
@anubhav756
anubhav756 requested a review from a team as a code owner August 20, 2026 08:57
@anubhav756
anubhav756 force-pushed the anubhav-secure-params-e2e branch from 249e5b5 to 2c8598e Compare August 20, 2026 10:08
Comment thread packages/toolbox-core/tests/test_e2e_mcp.py
Comment thread packages/toolbox-adk/tests/integration/test_integration.py Outdated
@anubhav756
anubhav756 force-pushed the anubhav-secure-params-e2e branch from 2c8598e to 976d2ba Compare August 21, 2026 11:52
Comment thread packages/toolbox-core/tests/test_e2e_mcp.py
@twishabansal twishabansal added the priority: p2 Moderately-important priority. Fix may not be included in next release. label Aug 25, 2026
@anubhav756
anubhav756 force-pushed the anubhav-secure-params-e2e branch from 976d2ba to 1ffd9c2 Compare August 25, 2026 07:26
@anubhav756 anubhav756 changed the title test(core): add end-to-end integration tests for secure parameters test: add end-to-end integration tests for secure parameters Aug 25, 2026
@anubhav756 anubhav756 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 25, 2026
@anubhav756

Copy link
Copy Markdown
Contributor Author

Adding "do not merge" label until v1.9.0 Toolbox server releases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

do not merge Indicates a pull request not ready for merge, due to either quality or timing. priority: p2 Moderately-important priority. Fix may not be included in next release.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants